Praise be to Allah.
The ruling is that this is haram. It must be noted that those who praise the Prophet (blessings and peace of Allah be upon him) fall into two categories:
The first category is those who praise him (blessings and peace of Allah be upon him) as he deserves, without reaching the level of exaggeration. There is nothing wrong with this, meaning that there is nothing wrong with praising the Messenger of Allah (blessings and peace of Allah be upon him) as he deserves, speaking of the perfect and praiseworthy qualities of his character and teachings (blessings and peace of Allah be upon him)).
The second category of those who praise the Messenger (blessings and peace of Allah be upon him) are those who go to the extreme that the Prophet (blessings and peace of Allah be upon him) prohibited when he said: “Do not exaggerate in praising me as the Christians exaggerated in praising the Messiah son of Maryam, for I am only a slave, so say: The slave of Allah and His Messenger.” Whoever praises the Prophet (blessings and peace of Allah be upon him) by saying that he is the helper of those who seek help, the one who answers the call of the desperate, or that he is the sovereign of this world and the hereafter, and has knowledge of the unseen, and other such words of praise, this type of praising him is haram. In fact, it may go as far as major shirk, which puts a person beyond the bounds of Islam. So it is not permissible to praise the Messenger (blessings and peace of Allah be upon him) in ways that reach the level of exaggeration, because the Prophet (blessings and peace of Allah be upon him) forbade that.
Now let us go back to the topic of taking permissible praise of the Prophet (blessings and peace of Allah be upon him) as a profession through which a person earns a living. We say that this is also haram and is not permissible, because praising the Messenger (blessings and peace of Allah be upon him) as he deserves – by referring to his noble and praiseworthy characteristics, and the guidance that he brought from Allah – is an act of worship by means of which a person may draw closer to Allah. If something is an act of worship, it is not permissible to take it as a means of worldly gain, because Allah, may He be exalted, says (interpretation of the meaning):
{Whoever desires the life of this world and its adornments - We fully repay them for their deeds therein, and they therein will not be deprived.
Those are the ones for whom there is not in the Hereafter but the Fire. And lost is what they did therein, and worthless is what they used to do} [Hud 11:15-16].
And Allah is the Guide to the straight path."( Majmu‘ Fatawa Ibn ‘Uthaymin 1/258).
Comment